This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
fix(solc): ensure flatten target is part of graph #2256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clippy failures are unrelated and false positives |
mattsse
force-pushed
the
matt/fix-ensure-flatten-target-is-part-of-graph
branch
from
a612cc7 to
704f720
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes foundry-rs/foundry#4545
this fixes an edge case where the target of flatten is not used by any project file and not included in the graph.
Solution
include target if missing to ensure it's part of the set
PR Checklist