Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

ethers-solc: support previous hardhat builds #676

Closed
mattsse opened this issue Dec 11, 2021 · 0 comments · Fixed by #677
Closed

ethers-solc: support previous hardhat builds #676

mattsse opened this issue Dec 11, 2021 · 0 comments · Fixed by #677

Comments

@mattsse
Copy link
Collaborator

mattsse commented Dec 11, 2021

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

  • ethers-solc and hardhat use different artifact layout but same cache format, so if a user has built with hardhat and then again with forge, we fail to decode the artifact because the cache tells us nothing has changed

Describe the solution you'd like
A clear and concise description of what you want to happen.
I believe we can simply change our format identifier and check if it's the hardhat one or ethers-solc one

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.
foundry-rs/foundry#209

meetmangukiya pushed a commit to meetmangukiya/ethers-rs that referenced this issue Mar 21, 2022

Verified

This commit was signed with the committer’s verified signature.
danharrin Dan Harrin
…akonst#676)

* feat(cast): Implemented cast index (seth feature parity gakonst#29)

* made the suggested changes after review gakonst#676
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant