This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
fix(solc): do not overwrite existing cache #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
force-pushed
the
fix/cache-incremental
branch
3 times, most recently
from
119d12a to
84dcd84
Compare
previously if 1 file changed, it'd overwrite the existing cache on disk with just that 1 changed file. this change reads the cache from disk and merges it with the new checksums
gakonst
force-pushed
the
fix/cache-incremental
branch
from
84dcd84 to
ff2fdff
Compare
|
Something minor to note here is that deleted files will remain in the cache metadata file. |
|
Wonder what's the best way to approach this to have a robust cache file |
ghost
mentioned this pull request
1 task
gakonst
added a commit
to foundry-rs/foundry
that referenced
this pull request
Nov 28, 2021
1. Introduces ethers-solc tracing
2. Fixes various ethers-solc caching bugs
gakonst/ethers-rs#623
gakonst/ethers-rs#629
gakonst/ethers-rs#630
gakonst
added a commit
to foundry-rs/foundry
that referenced
this pull request
Nov 28, 2021
1. Introduces ethers-solc tracing
2. Fixes various ethers-solc caching bugs
gakonst/ethers-rs#623
gakonst/ethers-rs#629
gakonst/ethers-rs#630
meetmangukiya
pushed a commit
to meetmangukiya/ethers-rs
that referenced
this pull request
Mar 21, 2022
* label cheatcode * no direct print (construct string) and label inputs/returns
charisma98
added a commit
to charisma98/foundry
that referenced
this pull request
Mar 4, 2023
1. Introduces ethers-solc tracing
2. Fixes various ethers-solc caching bugs
gakonst/ethers-rs#623
gakonst/ethers-rs#629
gakonst/ethers-rs#630
0129general
added a commit
to 0129general/FoundryProject
that referenced
this pull request
May 8, 2024
1. Introduces ethers-solc tracing
2. Fixes various ethers-solc caching bugs
gakonst/ethers-rs#623
gakonst/ethers-rs#629
gakonst/ethers-rs#630
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously if 1 file changed, it'd overwrite the existing cache on disk with just
that 1 changed file. this change reads the cache from disk and merges it with the new checksums
ref: #623