Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

Add rustls as a feature flag or use it by default. #325

Closed
shekohex opened this issue Jun 28, 2021 · 2 comments · Fixed by #330
Closed

Add rustls as a feature flag or use it by default. #325

shekohex opened this issue Jun 28, 2021 · 2 comments · Fixed by #330

Comments

@shekohex
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently, ethers-providers crate uses tokio-tungstenite with tls feature flag, which would use async-native-tls crate.
in Linux that means Openssl .. and you know what happens when you use Openssl and try to compile your cli/project to musl target!.

Describe the solution you'd like
I would like to have an option to enable the rustls-tls feature instead of the tls default one.
see: https://docs.rs/crate/tokio-tungstenite/0.14.0/features

Describe alternatives you've considered
Enable rustls-tls by default, which is more secure and more importantly easy to cross compile.

Additional context
CI Fails because of this: https://github.com/webb-tools/webb-rs/runs/2910394664?check_suite_focus=true

@gakonst
Copy link
Owner

gakonst commented Jul 5, 2021

@shekohex thanks for the issue! Could you check if #330 fixes it for you?

@shekohex
Copy link
Contributor Author

shekohex commented Jul 5, 2021

Yes, that is awesome.
Thank you!

meetmangukiya pushed a commit to meetmangukiya/ethers-rs that referenced this issue Mar 21, 2022
* Update README.md

Updated prank, prankStart and prankStop docs

* Updated docs

renamed startPrank and stopPrank

* chore: fix typos

Co-authored-by: Georgios Konstantopoulos <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants