Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: abstract file watching backend #22

Merged
merged 6 commits into from
Mar 20, 2023
Merged

feat: abstract file watching backend #22

merged 6 commits into from
Mar 20, 2023

Conversation

gajus
Copy link
Owner

@gajus gajus commented Mar 20, 2023

Keep running into implementation-specific issues:

  • Watchman is not tracking symbolic links (issue #105)
  • Chokidar is failing to detect file changes when multiple Chokidar processes are watching the same file (issue #1240)

Introducing this abstraction will help to switch between backends as needed.

This PR also adds fs.watch as a preferred backend on platforms that support it.

@gajus gajus temporarily deployed to release March 20, 2023 08:27 — with GitHub Actions Inactive
@gajus gajus temporarily deployed to release March 20, 2023 08:48 — with GitHub Actions Inactive
@gajus gajus temporarily deployed to release March 20, 2023 08:48 — with GitHub Actions Inactive
@gajus gajus temporarily deployed to release March 20, 2023 08:50 — with GitHub Actions Inactive
@gajus gajus temporarily deployed to release March 20, 2023 08:51 — with GitHub Actions Inactive
@gajus gajus temporarily deployed to release March 20, 2023 08:52 — with GitHub Actions Inactive
@gajus gajus temporarily deployed to release March 20, 2023 08:52 — with GitHub Actions Inactive
@gajus gajus merged commit 095316c into main Mar 20, 2023
@github-actions
Copy link

🎉 This PR is included in version 2.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant