Update source-map dependency #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firstly thanks very much for this excellent library.
I am running a Nodejs app and am hitting the following error when using this library:
```
You must provide the URL of lib/mappings.wasm by calling SourceMapConsumer.initialize({ 'lib/mappings.wasm': ... }) before using SourceMapConsumer
```
* A dependency of yours "source-map" detects the runtime (Nodejs vs browser) in a broken way. That library then throws an exception if some client-side-specific code is not run.
* The "check" checks for the presence of a variable "fetch" and the reasonable thinking is that only browsers will have fetch. The issue is that in my case and in some others (see [here](mozilla/source-map#349)) 3rd party libraries can define a variable "fetch" which triggers the described error.
None
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly thanks very much for this excellent library.
Problem
I am running a Nodejs app and am hitting the following error when using this library:
Diagnosis
Tests
None