Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nanoutils] cannot use create-index for short folders #51

Merged
merged 2 commits into from
Oct 27, 2019
Merged

[nanoutils] cannot use create-index for short folders #51

merged 2 commits into from
Oct 27, 2019

Conversation

Beraliv
Copy link
Contributor

@Beraliv Beraliv commented Feb 4, 2019

Real examples:

  • __
  • F
  • o
  • T

These methods haven't been included before, you can check it for https://www.npmjs.com/package/nanoutils/v/0.1.1 and previous versions (unfortunately 😢)

Solution: you can start file from _ and one symbol is required to make folders and files safe (not 2 as before)

@Beraliv
Copy link
Contributor Author

Beraliv commented Oct 26, 2019

ping @gajus
what do you think?

@gajus gajus merged commit 1f87f9a into gajus:master Oct 27, 2019
@gajus
Copy link
Owner

gajus commented Oct 27, 2019

I think these are horrible variable names, but as long as they are valid variable names, this library can support them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants