feat: babylon parser to check default/named exports #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a default export object containing all named exports.
Eg.:
```js
import _king from './king.js';
export const king = _king;
import _queen from './queen';
export const queen = _queen;
export default {
king,
queen
};
```
This adds support for `hyphenated-files` The exported names are now also in camelCase
# Conflicts: # src/utilities/createIndexCode.js
Uses Babylon parse to actually parse the file to check if it contains a default export.
If a file now contains a default export, the behaviour will be the same as before.
But if the file doesn't contain any default exports, assuming it has only named exports, it uses `* as` when creating its index.
Eg. Default export: (same as before)
```js
// foo.js
export default () => {}
```
will create ine the index:
```
import _foo from './foo'
export const foo = _foo
export {
foo
}
```
Eg. Named exports:
```js
// foo.js
export const foo1 = () => {}
export const foo2 = () => {}
```
will create ine the index:
```
import * as _foo from './foo'
export const foo = _foo
export {
foo
}
```
Similar to #18 This promotes bad design. Creating an index file that imports |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses Babylon parser to parse the file to check if it contains a default export.
If a file now contains a default export, the behaviour will be the same as before.
But if the file doesn't contain any default exports, assuming it has only named exports, it uses
* aswhen creating its index.Eg. Default export: (same as before)
will create ine the index:
Eg. Named exports:
will create ine the index:
Builds on #18, addresses #11