Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added job output #5

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Added job output #5

wants to merge 9 commits into from

Conversation

Skarlso
Copy link
Member

@Skarlso Skarlso commented Mar 7, 2020

No description provided.

Skarlso
Skarlso commented Mar 7, 2020
View reviewed changes
job.go Outdated
@@ -1,7 +1,7 @@
package golang

import (
"github.com/gaia-pipeline/protobuf"
"github.com/Skarlso/protobuf"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Skarlso don't forget to remove this after testing is done

Skarlso
Skarlso commented Mar 7, 2020
View reviewed changes
sdk.go Outdated
@@ -8,7 +8,7 @@ import (
"os"
"strings"

"github.com/gaia-pipeline/protobuf"
"github.com/Skarlso/protobuf"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Skarlso don't forget to remove this after testing is done.

@Skarlso
Copy link
Member Author

Skarlso commented Mar 7, 2020

@michelvocks please review. :)

@Skarlso
Copy link
Member Author

Skarlso commented Mar 7, 2020

Added job outputs to the gosdk gaia-pipeline/gaia#225

@Skarlso
Copy link
Member Author

Skarlso commented Mar 8, 2020

This is a breaking change. It will break existing jobs. So we should version it.

@Skarlso Skarlso mentioned this pull request Apr 15, 2020
Open
@Skarlso Skarlso mentioned this pull request Nov 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Skarlso