Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't reload functional properties #1002

Merged
merged 1 commit into from
Jun 5, 2018
Merged

Conversation

theKashey
Copy link
Collaborator

revert #949, fixes #995, #978, #969, #984

Implements #1001

Also fixes #969 with "this5", as long I've got _this9, and now using regexp to get the "right" _this[\d] from the code.

@codecov-io
Copy link

codecov-io commented Jun 4, 2018

Codecov Report

Merging #1002 into master will increase coverage by 1.11%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1002      +/-   ##
==========================================
+ Coverage   86.51%   87.62%   +1.11%     
==========================================
  Files          31       31              
  Lines         816      962     +146     
  Branches      192      254      +62     
==========================================
+ Hits          706      843     +137     
- Misses         91      101      +10     
+ Partials       19       18       -1
Impacted Files Coverage Δ
src/proxy/inject.js 77.58% <80%> (-0.2%) ⬇️
src/reconciler/proxies.js 100% <0%> (ø) ⬆️
src/reactHotLoader.js 96.22% <0%> (+2.28%) ⬆️
src/reconciler/hotReplacementRender.js 86% <0%> (+3.8%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7d7577...5bfd8cf. Read the comment docs.

@theKashey theKashey force-pushed the revert-function-apply branch from 7662c28 to 5bfd8cf Compare June 4, 2018 23:45
@theKashey theKashey merged commit c864343 into master Jun 5, 2018
@gregberge gregberge deleted the revert-function-apply branch July 11, 2018 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants