react-hot-loader breaks the page without react

[a1ooha]

Description

My project has a lot of pages, some of which don't use react, react-hot-loader breaks these pages.

Expected behavior

no react-hot-loader code in the js of the page.

Actual behavior

i add react in webpack externals, but do not add cdn link in this page. and react-hot-loader requires it, so "React is not defined", but i really don't need react. If i remove react-hot-loader/babel in .babelrc or remove react in externals or add cdn link in this page, everything will be ok.

Environment

React Hot Loader version: 4.2.0

Run these commands in the project folder and fill in their results:

1. node -v: 8.11.3
2. npm -v: 6.4.0

Reproducible Demo

.babelrc

{
    "presets": [
        [
            "env",
            {
                "targets": {
                    "node": "current",
                    "browsers": ["Android >= 4", "iOS >= 8", "last 3 versions"]
                }
            }
        ],
        "react"
    ],
    "plugins": [
        "transform-object-assign",
        "react-hot-loader/babel",
        "transform-class-properties",
        [
            "transform-runtime",
            {
                "polyfill": false,
                "regenerator": true
            }
        ]
    ]
}

webpack externals

externals: {
    vue: 'Vue',
    react: 'React',
    'react-dom': 'ReactDOM',
    'prop-types': 'PropTypes',
}

[theKashey]

Why you need React-Hot-Loader then?

[a1ooha]

Why you need React-Hot-Loader then?

Some of pages used react, and some simple page didn't. and they are in one project.

[theKashey]

Ok. Got the point. Probably that’s easy to fix.

[a1ooha]

Ok. Got the point. Probably that’s easy to fix.

So, what should i do to fix this problem？

[theKashey]

You can’t do it. It should be fixed inside RHL.
The best you may do - create a “broken” example I could convert to a test later.

[theKashey]

Ok. It's not possible to fix this issue from React-Hot-Loader side.

How to fix it:

• you have to create window.React variable. An empty one.

  window.React = null;

• you may do it instead of including React from CDN
• you may create a file and require it before react-hot-loader
• you will have to specify safetyNet: false option for RHL babel plugin (which is NOT released yet)

[theKashey]

The change was not released yet