-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #15 makeAssimilatePrototype invokes getters when copying me… #16
Conversation
This pull request is intended to fix gaearon/react-hot-loader#131 |
Thanks! I have a busy week but I'll come around to check this out in a week or so. |
👍 I've just seeing the same issue |
not trying to be that guy, but any chance we will see this merged and released? I need to turn off hot loading otherwise |
Just replaced npm's tip version of AFAIK, this is PR is a more generally correct method of transferring own-properties. 👍 |
I don't have time right now. I'm focused on getting Redux 1.0 out. I don't want to release a fix I have not tested extensively because it might break other people's stuff, and then I'd have to spend even more time when I don't have any. I will get back to improving React Hot Loader later this month, and then I'll make sure to merge this and other important fixes. Please have some more patience. :-) |
FYI, folks can use this in the interim by:
This is working for me, but I'm pretty new to React hot loading so I'm not sure what could go wrong. 😅 * |
Thanks for providing interim instrutions @benmosher! |
This is fixed in React Proxy in a slightly more accurate way. Thanks for the PR! |
Well, it seems this approach solved the issue