Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React fiber compatibility #5

Merged
merged 4 commits into from
Aug 8, 2017
Merged

Conversation

rafeca
Copy link

@rafeca rafeca commented Aug 8, 2017

This PR adds compatibility to the new React Fiber data structure. This fixes hot module reloading in React Native for React v16.

I've done the change in the 1.x branch, since this is the one used by the react-proxy module, which is used for HMR, but a very similar PR can be done for v2.

The tests haven't been changed, to ensure the backwards compatibility, but I have a commit which updates React to v16 to prove that this works on React Fiber (rafeca@2eb66a9).

Ideally we should have tests for different versions of React, but this is out of scope of this PR :)

@rafeca
Copy link
Author

rafeca commented Aug 8, 2017

@gaearon I've had to update a few dependencies in order to get the build passing:

@gaearon gaearon merged commit 9575735 into gaearon:1.x Aug 8, 2017
@gaearon
Copy link
Owner

gaearon commented Aug 8, 2017

Thanks!

@gaearon
Copy link
Owner

gaearon commented Aug 9, 2017

All released. Thank again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants