Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds compatibility to the new React Fiber data structure. This fixes hot module reloading in React Native for React v16.
I've done the change in the
1.x
branch, since this is the one used by thereact-proxy
module, which is used for HMR, but a very similar PR can be done for v2.The tests haven't been changed, to ensure the backwards compatibility, but I have a commit which updates React to v16 to prove that this works on React Fiber (rafeca@2eb66a9).
Ideally we should have tests for different versions of React, but this is out of scope of this PR :)