Skip to content

Conversation

@airhorns
Copy link
Contributor

@airhorns airhorns commented Jun 1, 2024

This upgrades the dev environment for MQT to node v22 from node v21. According to codspeed at least, the v8 upgrade buys at least 10% better performance across the board!

@codspeed-hq
Copy link

codspeed-hq bot commented Jun 1, 2024

CodSpeed Performance Report

Merging #99 will improve performances by 13.81%

Comparing node-22 (f1f22a0) with main (0ebab7f)

Summary

⚡ 9 improvements

Benchmarks breakdown

Benchmark main node-22 Change
instantiating a large union 86.2 µs 52 µs +65.79%
mobx-quick-tree ClassModel 52.6 µs 40 µs +31.48%
instantiating a diverse root 63.4 µs 47.3 µs +33.97%
instantiating a large root 3.7 ms 2.6 ms +44.07%
instantiating a small root 29 µs 21.5 µs +34.72%
accessing memoized getter properties of a class model 14.6 µs 11.4 µs +28.85%
accessing memoized null property of a class model 24.6 µs 19.4 µs +26.59%
accessing unmemoized getter properties of a class model 20.5 µs 16.3 µs +25.92%
accessing unmemoized null property of a class model 14.9 µs 13 µs +13.81%

@airhorns airhorns marked this pull request as ready for review June 6, 2024 00:01
@airhorns airhorns merged commit 603c08b into main Jun 6, 2024
@airhorns airhorns deleted the node-22 branch June 6, 2024 00:01
airhorns added a commit that referenced this pull request Jun 7, 2024
This reverts commit 603c08b, reversing
changes made to 5daccbe.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants