n-api: add fast paths for integer getters

Ref: nodejs#14379 PR-URL: nodejs#14393 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jason Ginchereau <[email protected]>
gabrielschulhof · Apr 10, 2018 · 55e3ca8 · 55e3ca8
1 parent e885661
commit 55e3ca8
Showing 1 changed file with 19 additions and 0 deletions.
diff --git a/src/node_api.cc b/src/node_api.cc
@@ -1912,6 +1912,12 @@ napi_status napi_get_value_int32(napi_env env,
   CHECK_ARG(env, result);
 
   v8::Local<v8::Value> val = v8impl::V8LocalValueFromJsValue(value);
+
+  if (val->IsInt32()) {
+    *result = val.As<v8::Int32>()->Value();
+    return napi_clear_last_error(env);
+  }
+
   RETURN_STATUS_IF_FALSE(env, val->IsNumber(), napi_number_expected);
 
   v8::Isolate* isolate = env->isolate;
@@ -1931,6 +1937,12 @@ napi_status napi_get_value_uint32(napi_env env,
   CHECK_ARG(env, result);
 
   v8::Local<v8::Value> val = v8impl::V8LocalValueFromJsValue(value);
+
+  if (val->IsUint32()) {
+    *result = val.As<v8::Uint32>()->Value();
+    return napi_clear_last_error(env);
+  }
+
   RETURN_STATUS_IF_FALSE(env, val->IsNumber(), napi_number_expected);
 
   v8::Isolate* isolate = env->isolate;
@@ -1950,6 +1962,13 @@ napi_status napi_get_value_int64(napi_env env,
   CHECK_ARG(env, result);
 
   v8::Local<v8::Value> val = v8impl::V8LocalValueFromJsValue(value);
+
+  // This is still a fast path very likely to be taken.
+  if (val->IsInt32()) {
+    *result = val.As<v8::Int32>()->Value();
+    return napi_clear_last_error(env);
+  }
+
   RETURN_STATUS_IF_FALSE(env, val->IsNumber(), napi_number_expected);
 
   // v8::Value::IntegerValue() converts NaN to INT64_MIN, inconsistent with