Fix issues retrieval for SonarQube Community Edition #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, |
|
Hi @gabrie-allaigre. Done! 😃 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the issue when using the Community Edition of SonarQube.
In this case the
SonarFacade.getNewIssues()method tries to retrieve issues from the SonarQube branch defined through thesonar.gitlab.ref_nameproperty, which is usually equal to the GitLab pipeline$CI_COMMIT_REF_NAMEvariable.Branch Analysis is though part of the Developer Edition (and above), so we need to handle that specific situation in order to avoid SonarQube / GitLab mismatches.