Update fmtlib fixed issues #2717
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To fix [fmtlib/fmt#3137](fmtlib/fmt#3137)
|
I’d rather wait for an official fmt release. @vitaut Is there an estimate for the next fmt release ? |
|
The new release should be in the next couple of weeks. |
|
Thanks @vitaut . Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because fmtlib fixes this problem, it hasn't been released yet. The spdlog lib binds it. In order to better use sdplog, I want to fix the error.
To fix fmtlib/fmt#3137
I know it is not a wise choice, but I can't think of a better way for people to avoid this mistake