Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Github Actions CI #2500

Merged
merged 3 commits into from
Oct 3, 2022
Merged

Migrate to Github Actions CI #2500

merged 3 commits into from
Oct 3, 2022

Conversation

offa
Copy link
Contributor

@offa offa commented Sep 29, 2022

Adds Github Actions CI and removes (no longer available) Travis CI.

This includes additional builds of latest Clang and GCC version with C++20 enabled.

Preparatory work

This is a draft since these two PRs are necessary to get a green build:

I'll rebase this PR once these two are merged.

@offa offa marked this pull request as ready for review October 1, 2022 16:17
@offa
Copy link
Contributor Author

offa commented Oct 1, 2022

PR rebased 👍

@gabime
Copy link
Owner

gabime commented Oct 1, 2022

Thanks @offa.
The thing is, that I lack the time for learning and/or supporting Actions CI.
If you have the time to support this, it would be great, otherwise I will have to pass.

@offa
Copy link
Contributor Author

offa commented Oct 2, 2022

Yes, let me know if there's something to do!

@gabime
Copy link
Owner

gabime commented Oct 2, 2022

Well for starters we need to replace the travis status icon with the Actions CI icon in readme.md

@offa
Copy link
Contributor Author

offa commented Oct 3, 2022

Seems I have missed that … 😆

Badge is updated and should become visible once Actions are active on the default branch.

@gabime
Copy link
Owner

gabime commented Oct 3, 2022

Whats the teeks99 line do?

matrix.config.compiler == 'clang' && 'teeks99/clang-ubuntu'

@offa
Copy link
Contributor Author

offa commented Oct 3, 2022

It selects the teeks99/clang-ubuntu docker image on Clang builds. GCC builds use the gcc image.

@gabime
Copy link
Owner

gabime commented Oct 3, 2022

why this particular image? seems like pretty obscure docker image. I hope we can live without it

@offa
Copy link
Contributor Author

offa commented Oct 3, 2022

Unlike GCC, there's no official Clang image (AFAIK). There are other images around, but that one works quite nice on CI, is based on Ubuntu, provides almost all version of Clang and is widely used.

I hope we can live without it

We could, but then we have to do all the work manually. In case where needed version of clang isn't shipped by the Actions runner, it'll become quite an effort.

@gabime gabime merged commit 936697e into gabime:v1.x Oct 3, 2022
@gabime
Copy link
Owner

gabime commented Oct 3, 2022

Thanks @offa . Looking good so far.

@offa offa deleted the ghactions_ci branch October 3, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants