Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump fmtlib to 6.0.0 #1213

Merged
merged 2 commits into from
Sep 6, 2019
Merged

Bump fmtlib to 6.0.0 #1213

merged 2 commits into from
Sep 6, 2019

Conversation

tgpfeiffer
Copy link
Contributor

I updated the files in include/spdlog/fmt/bundled to match the files in version 6.0.0 of fmt and updated src/fmt.cpp accordingly.

fixes #1077

@gabime gabime merged commit bf324a1 into gabime:v1.x Sep 6, 2019
@gabime
Copy link
Owner

gabime commented Sep 6, 2019

Thanks! meged

@gabime gabime mentioned this pull request Sep 6, 2019
Closed
@tgpfeiffer tgpfeiffer deleted the bump-fmtlib-6.0.0 branch September 9, 2019 03:46
@alium
Copy link

alium commented Sep 16, 2019

I tested build spdlog with fmt6 patch commit e149433
but build failed.
log: https://paste.artixlinux.org/view/95c96747

@gabime
Copy link
Owner

gabime commented Sep 16, 2019

It was fixed already. Please try latest commit

@alium
Copy link

alium commented Sep 16, 2019

yes, you right, it's fixed now , thanks

bachittle pushed a commit to bachittle/spdlog that referenced this pull request Dec 22, 2022
@lalitb
Add Aggregation Storage (gabime#1213)
ef3a623
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compiler warning with gcc-9 shipped with Fedora 30
3 participants
@tgpfeiffer @gabime @alium