Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dex] Fix 'staticClients' env variable usage #39

Merged
merged 1 commit into from
Dec 2, 2020

Conversation

xakraz
Copy link
Contributor

@xakraz xakraz commented Dec 2, 2020

Fixes #36
Relative to dexidp/dex#1664
Requires Dex >= v2.23.0

@xakraz
Copy link
Contributor Author

xakraz commented Dec 2, 2020

"Manually" tested on my deployments.

Makes the transition from:

  • id to idEnv
  • secret to secretEnv

❓ Maybe some documentation should be added to explain this "opinionated" way ?

@gabibbo97 gabibbo97 merged commit 2f677da into gabibbo97:master Dec 2, 2020
@gabibbo97
Copy link
Owner

Seems ok to me.
Thanks a lot!

About the second point, are you referring to something along the lines of "the splitting of configuration and env variables is because by doing so we can x,y,z" or some other thing?

@xakraz
Copy link
Contributor Author

xakraz commented Dec 2, 2020

@gabibbo97 About the doc, yes exactly.

Especially that the chart's user has still to use the format:

staticClients:
  - id: XXXXX
    secret: YYYY

It will be processed by the template and in the end translated as :

staticClients:
  - idEnv: XXXXX
    secretEnv: YYYY

@xakraz xakraz deleted the master branch January 24, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gabibbo97/dex chart: Invalid client_id ("example-app")
2 participants