-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GEOMETRY type #30
Comments
Hi @bkanuka , if they both have the data type and they work the same way, it's easy to add and I am happy to do it but would you be able to test the pull request on your hand? |
Absolutely I would test. They are the same type and are 90% the same. There's some implementation details of geometric functions that differ, but reading/writing wise should be identical |
@bkanuka I can see the data type on PostGIS here: https://postgis.net/docs/reference.html#PostGIS_Types However on BQ I checked https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types and https://cloud.google.com/bigquery/docs/geospatial-data and I do not see |
So sorry on my phone opening tickets late at night... |
Ok Sounds good! I created this PR: #30 I mapped both PostGIS types Can you try it and let me know? The steps should be:
Give me some feedback on the results and I will push the new version to Pypi |
@bkanuka did you get a chance to review this? |
Sorry, no 😕 I'm no longer at the company that was considering using this |
Both BigQuery and Postgres (with postgis extension) support a GEOMETRY data type. Will bigquery_fdw work with this?
The text was updated successfully, but these errors were encountered: