refactor entitlement proposal to apply to pods and builds #1
Conversation
|
@gabemontero here's the refactor PR i promised. |
gabemontero
left a comment
gabemontero
left a comment
There was a problem hiding this comment.
Just a few grammar/wording suggestions via suggested commits, as well as a call to remove CSI driver factoids and just reference the new PR (akin to removing broader scenario elements from the CSI driver PR and just reference this proposal).
Thanks for this rework and accelerating this along @bparees
| reference from a Pod and may only be referenced in a Pod via a `PersistentVolumeClaim` | ||
| - To that end, one of the sidecar containers, the [external provisioner](https://kubernetes-csi.github.io/docs/external-provisioner.html), | ||
| helps with this | ||
| - To that end, one of the sidecar containers, the [external provisioner](https://kubernetes-csi.github.io/docs/external-provisioner.html), helps with this |
There was a problem hiding this comment.
Similar to your suggestion in openshift/cluster-samples-operator#249, where we add a ref to this proposal and delete any repeat information, we should probably remove all these CSI factoids and simply add a ref to openshift/cluster-samples-operator#249, no?
There was a problem hiding this comment.
yeah probably, can i leave that as a cleanup for you after you merge this? you have a better understanding of CSI than me at this point and are probably better positioned to decide what minimal info needs to be provided here, vs what to defer to the lower level CSI EP.
also remove obsolete info
|
@gabemontero updates pushed other than dropping the CSI lifecycle bits |
yep was just about to ask about that ;-) ... thanks @bparees |
2 participants
also remove obsolete info