Removing check for secret that is not created#2
Closed
ricardomaraschini wants to merge 2 commits intogabemontero:del-install-secret-copyfrom
ricardomaraschini:remove-check-for-secret
Closed
Removing check for secret that is not created#2ricardomaraschini wants to merge 2 commits intogabemontero:del-install-secret-copyfrom ricardomaraschini:remove-check-for-secret
ricardomaraschini wants to merge 2 commits intogabemontero:del-install-secret-copyfrom
ricardomaraschini:remove-check-for-secret
Conversation
We are not copying this secret anymore.
Owner
|
yep that got added with a recent rebase I'll remove it in my PR directly - thanks @ricardomaraschini |
gabemontero
force-pushed
the
del-install-secret-copy
branch
from
7703d2f to
4a38483
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I understand we don't need this secret, right? If this makes no sense feel free to just close this.