Deduplicate view param #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellrott
approved these changes
Nov 24, 2020
aniewielska
force-pushed
the
deduplicate-view-param
branch
from
5424361
to
475cd49
Compare
|
@kellrott - please check again. I had to rebase the change on top of others and it looks validating correctly, but would like someone else to have a look as well. Also I reapplied your changes of field names in the comment of view parameter, hope no errors there as well. If it look OK to you, please merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR externalises the
viewparameter of list and get task.There is some problem generating GH pages after this change in my fork (but the files got generated in gh-pages), so let's see, if the problem is universal(it worked).