Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove /service-info endpoint (for now) #283

Merged

Conversation

dglazer
Copy link
Member

@dglazer dglazer commented Aug 3, 2019

Addresses DRS v1 PRC #11 /service-info items

Per PRC discussion, the GA4GH-wide /service-info spec isn't yet ready for use.

Per PRC discussion, the GA4GH-wide /service-info spec isn't yet ready for use.
@susheel
Copy link
Member

susheel commented Aug 5, 2019

I don't think this endpoint needs deletion for DRS v1, as points raised need to be addressed by Discovery and future inclusion post v1

@dglazer
Copy link
Member Author

dglazer commented Aug 5, 2019

I'm personally fine either way, so unless the PRC has a strong opinion, I defer to the group. The best argument for deleting it now is that, once there's a GA4GH-blessed cross-API /service-info definition, we can add it to DRS without a backwards-incompatible breaking change.

@susheel
Copy link
Member

susheel commented Aug 5, 2019

I'd keep the /service-info endpoint to at least provide users links to the documentation and contact points of the service, including being consistent with all other GA4GH APIs. Not a strongly held opinion and happy to defer to the community.

Once we get a GA4GH blessed /service-info spec, I suspect this will be a breaking change for all GA4GH APIs.

@susheel
Copy link
Member

susheel commented Aug 5, 2019

+0 ELIXIR

@ddietterich
Copy link
Contributor

+1 Terra
We'll support it as an extension and then totally replace it when the real thing comes along. No backward compatibility.

@Avantol13
Copy link

+1 from DCF/UChicago/CTDS/Gen3/

@mattions
Copy link

mattions commented Aug 9, 2019

+0 from Seven Bridges (CGC, Cavatica)
(Agreed that vocabulary should be shared among other Cloud WS APIs. Currently it might be useful to link to doc pages)

Copy link
Contributor

@briandoconnor briandoconnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Farewell /service-info, I'm sure we will see you again soon!

Seriously, though, I think it's best to remove it for now and I suspect it will be added in very late in the game before Oct's meeting. Implementers, I think it's fine to keep this in your implementations and tweak when the final version comes out.

@briandoconnor briandoconnor merged commit f0c84a2 into release/drs-1.0.0 Aug 12, 2019
@briandoconnor briandoconnor deleted the feature/issue-000-remove-serviceinfo branch August 12, 2019 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants