#87: Expand examples and add examples documentation #123
Conversation
|
Grr... some of the example validations are having issue with Variations listed under |
There was a problem hiding this comment.
This is a really nice enhancement to the docs and examples. I did not check every value, but the presentation and content of the readme looks like a good improvement.
The only cosmetic feedback I would suggest (for future) is to not use double quotes as much in the text for readers but instead use italics or bold for key values and limit the use of quoted or double-quoted terms.
If you have any thoughts, I'd love to hear them! No worries either way. It seems mostly an issue with |
* MSP update * Cleaned up whitespace issues
There was a problem hiding this comment.
With tests passing I approve this
@brendanreardon you or @DanielPuthawala can review my fixes to the examples that helped make the tests pass and if you are okay. please merge this so I can build the Ballot branch.
🤦 I can't believe that I missed that. Thank you, Larry! |
|
Can I merge it? I went for it |
* #87: Expand examples and add examples documentation (#123) * align to branch id --------- Co-authored-by: Brendan Reardon <[email protected]> Co-authored-by: James Stevenson <[email protected]>
Updated all examples and wrote a README that details how each example was generated. This branch was regenerated relative to 87-add-examples because that branch was created before the updates to gks-core and VRS, and it is resulting in a many merging issues.