Don't put .then inside a .then

[neugierige]

const update = (req, res, next) => {
  let search = { _id: req.params.id, _owner: req.currentUser._id };
  Example.findOne(search)
    .then(example => {
      if (!example) {
        return next();
      }
      delete req.body._owner;  // disallow owner reassignment.
      return example.update(req.body.example)
        .then(() => res.sendStatus(200));
    })
    .catch(err => next(err));
};

should be updated to:

const update = (req, res, next) => {
  let search = { _id: req.params.id, _owner: req.currentUser._id };
  Example.findOne(search)
    .then(example => {
      if (!example) {
        return next();
      }
      delete req.body._owner;  // disallow owner reassignment.
      return example.update(req.body.example);
    })
    .then(() => res.sendStatus(200))
    .catch(err => next(err));
};

@raq929

[neugierige]

also appears in const destroy

[gaand]

I believe this refactoring contains a bug. Both next and res.sendStatus will run if example is falsy.

[raq929]

Yeah, Antony and I talked, and changed this back. I still want to refactor, but a different way.

…

On Tue, Dec 13, 2016, 1:58 PM Antony Donovan ***@***.***> wrote: I believe this refactoring contains a bug. Both next and res.sendStatus will run if example is falsy. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#36 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ANRw2G8iu9V47UJHGfcEZYGLEh1QyUm_ks5rHuq-gaJpZM4LK_MS> .

[raq929]

See ga-wdi-boston/express-api-template-ARCHIVED#33