Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use biome #1781

Merged
merged 7 commits into from
Jan 28, 2024
Merged

chore: use biome #1781

merged 7 commits into from
Jan 28, 2024

Conversation

9renpoto
Copy link
Member

@9renpoto 9renpoto commented Jan 20, 2024

use biomejs

bugfix: biomejs/biome#1612

@9renpoto 9renpoto self-assigned this Jan 20, 2024
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [lts/*, latest]

steps:
- uses: actions/checkout@v4
uses: biomejs/setup-biome@v2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[actionlint] reported by reviewdog 🐶
key "uses" is duplicated in element of "steps" section. previously defined at line:15,col:9 [syntax-check]

.github/workflows/nodejs.yml Show resolved Hide resolved
Copy link

codecov bot commented Jan 20, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (fac21d5) 79.16% compared to head (fc1ebfc) 79.16%.

Files Patch % Lines
...ackages/nestjs-graphql-relay/src/connectionArgs.ts 0.00% 4 Missing ⚠️
...ckages/nestjs-slack-webhook/src/slackCoreModule.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1781   +/-   ##
=======================================
  Coverage   79.16%   79.16%           
=======================================
  Files          19       19           
  Lines         216      216           
  Branches       35       36    +1     
=======================================
  Hits          171      171           
  Misses         44       44           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@9renpoto 9renpoto added the Type: Refactoring A code change that neither fixes a bug nor adds a feature label Jan 20, 2024
@9renpoto 9renpoto merged commit 3fe8825 into main Jan 28, 2024
9 of 10 checks passed
@9renpoto 9renpoto deleted the feature/interface branch January 28, 2024 02:28
@github-actions github-actions bot mentioned this pull request Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Refactoring A code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant