Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve embedded field types #32

Merged
merged 1 commit into from
Oct 31, 2024
Merged

fix: resolve embedded field types #32

merged 1 commit into from
Oct 31, 2024

Conversation

g4s8
Copy link
Owner

@g4s8 g4s8 commented Oct 31, 2024

Fix: #29

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 48.85%. Comparing base (3c8918d) to head (acefaee).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
converter.go 40.00% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
- Coverage   49.16%   48.85%   -0.32%     
==========================================
  Files          11       11              
  Lines         602      610       +8     
==========================================
+ Hits          296      298       +2     
- Misses        286      291       +5     
- Partials       20       21       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@g4s8 g4s8 merged commit f8c78f7 into master Oct 31, 2024
3 of 5 checks passed
@g4s8 g4s8 deleted the i30 branch October 31, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Embedded config is not being parse correctly
1 participant