Skip to content
This repository has been archived by the owner on Jul 30, 2019. It is now read-only.

Send to #channel suddenly stopped working #3 #21

Closed
bekoeppel opened this issue Jan 29, 2019 · 9 comments
Closed

Send to #channel suddenly stopped working #3 #21

bekoeppel opened this issue Jan 29, 2019 · 9 comments

Comments

@bekoeppel
Copy link

Since today, my "Send to #channel" doesn't work anymore. The box is just always un-ticked, as if the extension wasn't running.

I have the following setting:

  • Threads on channel by default: ON
  • Make "send to channel" sticky: ON

image

I don't see any errors in the console log of Slack, or in the background page console log of the plugin.

@g3rv4
Copy link
Owner

g3rv4 commented Jan 29, 2019

I was able to reproduce the issue... working on a fix ;)

g3rv4 pushed a commit that referenced this issue Jan 29, 2019
@g3rv4
Copy link
Owner

g3rv4 commented Jan 29, 2019

@bekoeppel shipped v2.2.3.2 to Chrome and Firefox (Opera takes ages). Can you please update and let me know if it's fixed?

Thanks!

@bekoeppel
Copy link
Author

Awesome, thanks for the fast fix! Works again :-)

@g3rv4 g3rv4 closed this as completed Jan 30, 2019
@bekoeppel
Copy link
Author

Hi @g3rv4. I just noticed that it doesn't fully work. The checkbox for "Also send to #channel" is now ticked automatically, but then when sending the message, it is not sent to the channel. If I untick the checkbox, and tick it again (by clicking on it), then it works.

@g3rv4
Copy link
Owner

g3rv4 commented Feb 2, 2019

ugh, our good friends at Slack changing things again... checking it out

@g3rv4 g3rv4 reopened this Feb 2, 2019
g3rv4 pushed a commit that referenced this issue Feb 4, 2019
Broken after Slack started using React for that flow
refs #21
@g3rv4
Copy link
Owner

g3rv4 commented Feb 4, 2019

@bekoeppel alright... I fixed it on commit a465f7a using this ugly hack.

I'm very tempted to kill those 2 features. The main reason to do it is... I don't use them anymore since I added the ability to broadcast all the messages.

I'm working on improving it a little bit. How sad (on a scale of 1-10) would you be if I did indeed kill those features?

Please update to v2.2.3.3 and let me know if it's working for you now.

@bekoeppel
Copy link
Author

@g3rv4 great, thanks! I tried v2.2.3.3, and it works again.

I'm working on improving it a little bit. How sad (on a scale of 1-10) would you be if I did indeed kill those features?

My sadness would be ∞. Thats the only feature I use from your extension at the moment, and it perfectly solves my need of always having "Respond to #channel" turned on.

The broadcast feature and keeping multiple channels open in multiple tabs wouldn't really work for me. I am in about 100 channels or so, and very often use the Ctrl-K shortcut to open the "Jump to" window to go to another channel quickly. So I would need 100 tabs, and couldn't use Ctrl-K anymore, because I would have to check another tab instead.

@g3rv4
Copy link
Owner

g3rv4 commented Feb 5, 2019

alright, infinite level of sadness is definitely too much.

They’re staying :) thanks for verifying the fix!

@g3rv4 g3rv4 closed this as completed Feb 5, 2019
@g3rv4
Copy link
Owner

g3rv4 commented Feb 13, 2019

@bekoeppel would you mind checking visible threads? it's the same feature but improved greatly (now you don't need to keep different channels open in different tabs, stuff works exactly as I would expect it to).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants