Fix #280, blur font on darwin #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Font's on retina will be blur cause Rentina have 2x DPI Now we times the DPI by 2 when on darwin, and scale the Label panel by 0.5 to keep the original size Since we scaled the panel size back, so it should not affect much on non-Rentina darwin However, if you are using non-darwin with rentina monitor, issue g3n#280 will still happen, need a way to detect the monitor
|
Before: After: |
This was referenced Dec 3, 2023
…t of shape" I was completely wrong, we should divide on the floor or the text won't keep it's original size This reverts commit 73f1b6a.
|
Nice work, thanks! |
xackery
pushed a commit
to xackery/engine
that referenced
this pull request
Feb 28, 2024
* fix g3n#280 Font's on retina will be blur cause Rentina have 2x DPI Now we times the DPI by 2 when on darwin, and scale the Label panel by 0.5 to keep the original size Since we scaled the panel size back, so it should not affect much on non-Rentina darwin However, if you are using non-darwin with rentina monitor, issue g3n#280 will still happen, need a way to detect the monitor * remove a debug log * we should devide on int but not floor, or the text will be out of shape * Revert "we should devide on int but not floor, or the text will be out of shape" I was completely wrong, we should divide on the floor or the text won't keep it's original size This reverts commit 73f1b6a. * use `window.Get().GetScale()` instead of hardcoded size and os * use explicit rune casting to pass `go test` * fix format for font.go * fix for Edit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Font's on retina will be blur cause Rentina have 2x DPI
Now we times the DPI by 2 when on darwin, and scale the Label panel by 0.5 to keep the original size
Since we scaled the panel size back, so it should not affect much on non-Rentina darwin
However, if you are using non-darwin with rentina monitor, issue #280 will still happen, need a way to detect the monitor