Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forget to generate wrapper code to enable ZeroCopyBuffer #2

Closed
fzyzcjy opened this issue Oct 5, 2021 · 2 comments
Closed

Forget to generate wrapper code to enable ZeroCopyBuffer #2

fzyzcjy opened this issue Oct 5, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@fzyzcjy
Copy link
Owner

fzyzcjy commented Oct 5, 2021

Look at how allo-isolate enable zero-copy buffer: shekohex/allo-isolate#3

in other words, we cannot do Vec<u8>.into_dart(), but need to wrap with this (zero cost) ZeroCopyBuffer struct.
@fzyzcjy
Copy link
Owner Author

fzyzcjy commented Oct 5, 2021

Will be solved possibly today, definitely before publishing packages

@fzyzcjy fzyzcjy added the bug Something isn't working label Oct 5, 2021
fzyzcjy added a commit that referenced this issue Oct 5, 2021
@fzyzcjy
try to fix bug of forgetting to generate ZeroCopyBuffer wrapper #2
efc6dac
fzyzcjy added a commit that referenced this issue Oct 5, 2021
@fzyzcjy
add integration test for #2
1a9b67f
@fzyzcjy fzyzcjy closed this as completed Oct 5, 2021
@github-actions
Copy link
Contributor

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fzyzcjy