Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

Added few countries to he_IL Provider file Address.php #830

Closed
wants to merge 1 commit into from
Closed

Added few countries to he_IL Provider file Address.php #830

wants to merge 1 commit into from

Conversation

jremes-foss
Copy link
Contributor

Good morning. I added few countries to he_IL provider file Address.php.

Thank you.

@fzaninotto
Copy link
Owner

Could you list all countries instead? Currently, this provider has very low value.

@jremes-foss
Copy link
Contributor Author

Sure, just let me to re-factor the provider a bit. =)

@yonirom
Copy link
Contributor

yonirom commented Feb 28, 2016

I'm sorry, I just saw this PR now.
I saw the TODO in the he_IL provider and went on and created a PR (#841).

Also, why does this provider have very low value? From what i've seen only Payment and Text are missing. Payment is relatively new and can be implemented quite easily. Text is a bit more difficult.

@fzaninotto
Copy link
Owner

Superseded by #841

@fzaninotto fzaninotto closed this Feb 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants