Skip to content
This repository was archived by the owner on Dec 11, 2020. It is now read-only.

Curly braces for arrays is deprecated in PHP 7.4 #1843

Merged
merged 1 commit into from
Nov 23, 2019
Merged

Curly braces for arrays is deprecated in PHP 7.4 #1843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Faker/Calculator/Luhn.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ private static function checksum($number)
$length = strlen($number);
$sum = 0;
for ($i = $length - 1; $i >= 0; $i -= 2) {
$sum += $number{$i};
$sum += $number[$i];
}
for ($i = $length - 2; $i >= 0; $i -= 2) {
$sum += array_sum(str_split($number{$i} * 2));
$sum += array_sum(str_split($number[$i] * 2));
}

return $sum % 10;
Expand Down
4 changes: 2 additions & 2 deletions test/Faker/Provider/fi_FI/PersonTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,12 @@ public function testPersonalIdentityNumberGeneratesCompliantNumbers()
public function testPersonalIdentityNumberGeneratesOddValuesForMales()
{
$pin = $this->faker->personalIdentityNumber(null, 'male');
$this->assertEquals(1, $pin{9} % 2);
$this->assertEquals(1, $pin[9] % 2);
}

public function testPersonalIdentityNumberGeneratesEvenValuesForFemales()
{
$pin = $this->faker->personalIdentityNumber(null, 'female');
$this->assertEquals(0, $pin{9} % 2);
$this->assertEquals(0, $pin[9] % 2);
}
}
4 changes: 2 additions & 2 deletions test/Faker/Provider/sv_SE/PersonTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,12 @@ public function testPersonalIdentityNumberGeneratesLuhnCompliantNumbers()
public function testPersonalIdentityNumberGeneratesOddValuesForMales()
{
$pin = $this->faker->personalIdentityNumber(null, 'male');
$this->assertEquals(1, $pin{9} % 2);
$this->assertEquals(1, $pin[9] % 2);
}

public function testPersonalIdentityNumberGeneratesEvenValuesForFemales()
{
$pin = $this->faker->personalIdentityNumber(null, 'female');
$this->assertEquals(0, $pin{9} % 2);
$this->assertEquals(0, $pin[9] % 2);
}
}