Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

Fixing sk_SK men last names set #1459

Merged

Conversation

pavoltanuska
Copy link
Contributor

In Slovak language, the suffix "-ová" belongs to female names only - both of these names' (Hečková, Jurinová) male counterparts are already part of the men set (Hečko, Jurina).

However, I'm not sure if I'm not breaking a part of Contributing guidelines with this PR, specifically:

Avoid changing existing sets of data. Some developers use Faker with seeding for unit tests ; changing the data makes their tests fail.

If that's the case, feel free to close and not merge this PR :)

@fzaninotto fzaninotto merged commit f6706bf into fzaninotto:master Sep 17, 2019
@fzaninotto
Copy link
Owner

Thanks!

@pavoltanuska pavoltanuska deleted the sk_SK_fixing_last_name_male_set branch September 17, 2019 13:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants