Added E.164 support as per issue #668

Consolidated commit

readme.md

@@ -161,6 +161,7 @@ Each of the generator properties (like `name`, `address`, and `lorem`) are calle
 
     phoneNumber             // '201-886-0269 x3767'
     tollFreePhoneNumber     // '(888) 937-7238'
+    e164PhoneNumber     // '+27113456789'
 
 ### `Faker\Provider\en_US\Company`
 

src/Faker/Provider/PhoneNumber.php

@@ -13,4 +13,14 @@ public function phoneNumber()
     {
         return static::numerify($this->generator->parse(static::randomElement(static::$formats)));
     }
+
+    /**
+     * @example +27113456789
+     * @return string
+     */
+    public function e164PhoneNumber()
+    {
+        $formats = array('+#############');
+        return static::numerify($this->generator->parse(static::randomElement($formats)));
+    }
 }

src/Faker/UniqueGenerator.php

@@ -14,6 +14,7 @@ class UniqueGenerator
 
     /**
      * @param Generator $generator
+     * @param $maxRetries
      */
     public function __construct(Generator $generator, $maxRetries)
     {
@@ -24,6 +25,7 @@ public function __construct(Generator $generator, $maxRetries)
     /**
      * Catch and proxy all generator calls but return only unique values
      * @param string $attribute
+     * @return mixed
      */
     public function __get($attribute)
     {
@@ -34,6 +36,7 @@ public function __get($attribute)
      * Catch and proxy all generator calls with arguments but return only unique values
      * @param string $name
      * @param array $arguments
+     * @return mixed
      */
     public function __call($name, $arguments)
     {

test/Faker/Provider/PhoneNumberTest.php

@@ -0,0 +1,28 @@
+<?php
+
+namespace Faker\Test\Provider;
+
+use Faker\Generator;
+use Faker\Provider\PhoneNumber;
+
+class PhoneNumberTest extends \PHPUnit_Framework_TestCase
+{
+
+    /**
+     * @var Generator
+     */
+    private $faker;
+
+    public function setUp()
+    {
+        $faker = new Generator();
+        $faker->addProvider(new PhoneNumber($faker));
+        $this->faker = $faker;
+    }
+
+    public function testPhoneNumberFormat()
+    {
+        $number = $this->faker->e164PhoneNumber();
+        $this->assertRegExp('/^\+[0-9]{11,}$/', $number);
+    }
+}

test/Faker/Provider/ProviderOverrideTest.php

@@ -112,6 +112,7 @@ public function testPhoneNumber($locale = null)
         $faker = Faker\Factory::create($locale);
 
         $this->assertRegExp(static::TEST_STRING_REGEX, $faker->phoneNumber);
+        $this->assertRegExp(static::TEST_STRING_REGEX, $faker->e164PhoneNumber);
     }
 
 

test/test.php

@@ -9,6 +9,7 @@
 <?php for ($i=0; $i < 10; $i++): ?>
   <contact firstName="<?php echo $faker->firstName ?>" lastName="<?php echo $faker->lastName ?>" email="<?php echo $faker->email ?>" >
     <phone number="<?php echo $faker->phoneNumber ?>"/>
+    <phone number="<?php echo $faker->e164PhoneNumber ?>" format="E164"/>
 <?php if ($faker->boolean(25)): ?>
     <birth date="<?php echo $faker->dateTimeThisCentury->format('Y-m-d') ?>" place="<?php echo $faker->city ?>"/>
 <?php endif; ?>