Skip to content

Conversation

@xzys
Copy link

@xzys xzys commented Aug 20, 2014

I just saw that there was another ID3 tag pull request. damn.

But I made two other minor changes in there which might be good.

  1. I just moved the fetching code below the file check, so that if you already have the file, it wont re-download it. Speeds up the script a little bit.
  2. It asks user input for the area to scrape and number of pages so you don't have to go into the file to change parameters. Just pressing enter when it asks passes in default parameters.
  3. And yes, it adds simple artist and title ID3 tags using mutagen.

@fzakaria
Copy link
Owner

This looks pretty good.
Let me try it out but i don't see anything wrong with it.
I like the simplicity.

@xzys
Copy link
Author

xzys commented Aug 21, 2014

cool! this is insanely useful to me so I might add some more things for myself.

@fzakaria
Copy link
Owner

I don't want to add much more (and even the tags I might consider in a
separate branch).
I wanted to keep the script small enough so people could learn from it and
just incorporate it into their own scripts / tools.

I didn't want it to be a catch all script :)
Maybe it should have an examples folder?

Farid Zakaria

On Thu, Aug 21, 2014 at 7:07 AM, Sachin Rudraraju [email protected]
wrote:

cool! this is insanely useful to me so I might add some more things for
myself.


Reply to this email directly or view it on GitHub
#15 (comment).

@xzys
Copy link
Author

xzys commented Aug 21, 2014

Oh no I understand, I just meant in my own branch. I make music so fetching bpm, key and maybe album art would be great for me.

@fzakaria
Copy link
Owner

Checkout: http://developer.echonest.com/
I originally had a tool that would use their API to extract stuff (like key)

Farid Zakaria

On Thu, Aug 21, 2014 at 9:35 AM, Sachin Rudraraju [email protected]
wrote:

Oh no I understand, I just meant in my own branch. I make music so
fetching bpm, key and maybe album art would be great for me.


Reply to this email directly or view it on GitHub
#15 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants