Use Staticcheck v0.5.1 in CI infrastructure #5175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mainly does two things: - Uses Go 1.22 instead of 1.21 as the highest version (I don't have 1.23 on Fedora 40 yet so did not want to bump to latest just yet). - We now always pull the latest setup-go-faster action in v1 without having to manually change version.
This fixes a few code errors that slipped through review (thankfully now handled by Staticcheck for us) and makes sure we are using the latest version.
Haven't quite gotten used to Nvim yet ;)
6 tasks
This should be safer than ever given that some new features are dependent on the version in go.mod.
|
Test coverage lowered without changing tests? Let's see if a kick fixes it 😅 |
I think sometimes Coveralls gets confused with multiple branches building |
andydotxyz
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This makes sure that we are using the latest version in CI and updates the code to fix those issues.
It also includes a patch that I forgot to push a while ago about making the CI use Go 1.22 (then also a bump to Go 1.23 while at it) and also always pull the latest version of the setup-go-faster action.
Should hopefully unblock #5121
Checklist: