Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: command to scan for new translation #5168

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

sdassow
Copy link
Contributor

@sdassow sdassow commented Sep 27, 2024

Description:

Adds a translate command that scans for new translation and updates the translations file. No tests and nothing yet, this is to get initial feedback and see what else it needs to be acceptable for a merge.

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

Where applicable:

  • Public APIs match existing style and have Since: line.
  • No breaking changes (new command).
  • Check for binary size increases when importing new modules.

Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please factor code out of the 'Translate' method? 120 lines seems very long for something that could be broken down. That would also facilitate adding a test :).

Lastly do note to check the boxes on your PR template so we can see where it's at

@coveralls
Copy link

Coverage Status

coverage: 65.697% (-0.3%) from 66.027%
when pulling cced842 on sdassow:add-translate-command
into 119d2f8 on fyne-io:develop.

@andydotxyz
Copy link
Member

Just FYI we have now update the CI version requirements so you'll need to rebase on latest develop to get a full build to pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants