Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read double click delay time from OS #5036

Merged
merged 4 commits into from
Aug 3, 2024
Merged

Read double click delay time from OS #5036

merged 4 commits into from
Aug 3, 2024

Conversation

dweymouth
Copy link
Contributor

@dweymouth dweymouth commented Jul 27, 2024 •
edited
Loading

Description:

On Mac and Windows, use OS APIs to read the system double click interval

Fixes #4448

Checklist:

  • Tests included. <- tested manually on Mac and Windows
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

coveralls commented Jul 27, 2024 •
edited
Loading

Coverage Status

coverage: 66.04% (-0.006%) from 66.046%
when pulling 65c9cd1 on dweymouth:os-doubleclick
into 49ad989 on fyne-io:release/v2.5.x.

@dweymouth dweymouth marked this pull request as ready for review July 27, 2024 16:09
@dweymouth dweymouth requested a review from andydotxyz July 27, 2024 16:12
andydotxyz
andydotxyz reviewed Jul 30, 2024
View reviewed changes
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one thanks for this.

Just a note inline that the new methods returning a hard-coded number should all use the same const which was moved just to the windows driver. (note: not tested yet, just reviewing the code)

andydotxyz
andydotxyz approved these changes Aug 3, 2024
View reviewed changes
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice on the DLL cleanup too

@dweymouth dweymouth merged commit 9592a7b into fyne-io:release/v2.5.x Aug 3, 2024
12 checks passed
@dweymouth dweymouth deleted the os-doubleclick branch August 3, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andydotxyz andydotxyz andydotxyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dweymouth @coveralls @andydotxyz