Fix recognition of missing XDG user directories #4650
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In
dialog/file_xdg.go
there was some code to check, if a user directory does not exist. This code did not work for me, becauselocURI.String()
was, for example,file:///home/richard/
when the "Videos" directory wasn't found.homeUri.Strin()
wasfile:///home/richard
.I am not sure if
xdg-user-dir
always outputs the trailing slash, so I took a conservative approach and usedstrings.TrimRight
.I've added a second commit, which prevents the errors from
getFavoriteLocation
to be overwritten by errors fromstorage.ListerForURI
.Checklist: