-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check widget: Only respond to hover and tap over the checkbox or label #4526
Conversation
Did you mean to request a review? :) |
Yes, this pr is ready for review :) |
I mean given that you assigned me and Andrew to it? ;) |
Just wasn't sure how you had notifications setup |
Alright, cool. Absolutely no problem. Just though you might have wanted us to do something else than review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Really nice change. More consistency with the Radio
widget 👍
Just left one minor suggestion inline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful work. Thanks :)
Description:
Fixes #4527, related to #4320
Updates the Check widget to only respond to hover and tap events over either the checkbox or the label area of the widget. If the widget is wider or taller because it is placed in a container that maximizes its size, ignore events outside the "active" area of the widget.
The first commit of this PR just reordered the functions in
check.go
in a way that made more sense (resulting in an inflated line count diff relative to the actual code change). To review, you may wish to only look at the second commit.Note: the behavior can be tested with fyne_demo. Before this change the check widget could be toggled by tapping far to the right, well beyond the end of the label. With the behavior, tapping/hovering in that area of the widget (which intuitively to the user is not part of the widget at all) does nothing
Checklist: