Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missed truncation mode for hyperlink #4335

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Add missed truncation mode for hyperlink #4335

merged 1 commit into from
Oct 20, 2023

Conversation

andydotxyz
Copy link
Member

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.
  • Public APIs match existing style and have Since: line.

@andydotxyz
Copy link
Member Author

andydotxyz commented Oct 20, 2023 •
edited
Loading

(Doesn't!) Fixes #4336 :)

@dweymouth
Copy link
Contributor

Fixes #4336 :)

I believe to fix #4336 we need to sync the truncation mode set on the parent RichText to the individual Hyperlink widgets that implement the HyperlinkSegments in richtext.go (or richtext_objects.go?)

@andydotxyz
Copy link
Member Author

Oh yes I missed that. Would you like me to add that here as well, or is it another PR?

@dweymouth
Copy link
Contributor

Either one works, whichever's easier!

@andydotxyz
Copy link
Member Author

Ok, let's leave it for now - it's actually more complex as the row layout code needs to understand that hyperlink can be truncated

@andydotxyz andydotxyz merged commit 2921c11 into fyne-io:develop Oct 20, 2023
10 of 11 checks passed
@andydotxyz andydotxyz deleted the fix/hyperlinktruncate branch October 20, 2023 17:20
dweymouth added a commit to dweymouth/fyne that referenced this pull request Nov 4, 2023
@dweymouth
Pull in unreleased Hyperlink truncation property from fyne-io/pull/4335
f124004
dweymouth added a commit to dweymouth/fyne that referenced this pull request Nov 23, 2023
@dweymouth
Pull in unreleased Hyperlink truncation property from fyne-io/pull/4335
0d0cd3f
dweymouth added a commit to dweymouth/fyne that referenced this pull request Jan 12, 2024
@dweymouth
Pull in unreleased Hyperlink truncation property from fyne-io/pull/4335
ade0417
dweymouth added a commit to dweymouth/fyne that referenced this pull request Feb 14, 2024
@dweymouth
Pull in unreleased Hyperlink truncation property from fyne-io/pull/4335
d5a38e1
@dweymouth dweymouth added this to the "Elgin" release, early 2024 milestone Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dweymouth dweymouth dweymouth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
"Elgin" release, early 2024
Development

Successfully merging this pull request may close these issues.
2 participants
@andydotxyz @dweymouth