Fix #4260: Synchronize access to fileDialog.data file list #4279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jacalz
requested changes
Sep 24, 2023
Jacalz
reviewed
Sep 24, 2023
added 2 commits
September 24, 2023 10:37
…ly create the mutex in all struct definitions
Jacalz
previously approved these changes
Sep 27, 2023
dweymouth
reviewed
Sep 27, 2023
dweymouth
approved these changes
Sep 27, 2023
|
We've had some problems with some strange test failures in our CI workflow lately. I'll rerun and try to merge as soon as I can :) |
|
Thanks for all the reviews! |
|
Thank you for your work. It is much appreciated :) |
andydotxyz
pushed a commit
that referenced
this pull request
Oct 4, 2023
This change adds a RWMutex to synchronize access to the fileDialog.data file list. The refreshDir function clears and rebuilds fileDialog.data, meanwhile, several other functions are indexing into it. This allowed for scenarios where fileDialog.data was either nil or smaller than expected when indexing into it. Fixes #4260
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This change adds a RWMutex to synchronize access to the
fileDialog.datafile list.The
refreshDirfunction clears and rebuildsfileDialog.data, meanwhile, several other functions are indexing into it.This allowed for scenarios where
fileDialog.datawas either nil or smaller than expected when indexing into it.Fixes #4260
Checklist: