Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't actually re-load our images when they are resized unless SVG #4088

Merged
merged 2 commits into from
Jul 30, 2023
Merged

Don't actually re-load our images when they are resized unless SVG #4088

merged 2 commits into from
Jul 30, 2023

Conversation

andydotxyz
Copy link
Member

If the pixel info is loaded the GPU can do the rest

Fixes #4080

Checklist:

  • Tests included. <- different threading model for tests
  • Lint and formatter run with no errors.
  • Tests all pass.

@andydotxyz
Don't actually re-load our images when they are resized unless SVG
cf7815a 
If the pixel info is loaded the GPU can do the rest
@andydotxyz
Copy link
Member Author

Wow, did not expect so many platform tests to break with this, will have to look into why...

@andydotxyz
If we have not rendered before a resize could refresh...
d8b451d 
Mostly used for testing but no big deal
@coveralls
Copy link

Coverage Status

coverage: 66.165% (-0.008%) from 66.173% when pulling d8b451d on andydotxyz:fix/4080 into 238f389 on fyne-io:develop.

Jacalz
Jacalz approved these changes Jul 30, 2023
View reviewed changes
Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if the reporter in the issue sees the issue as entirely fixed (the discussion in the ticket seems to be incomplete). This does seem to improve things so I'll approve.

@andydotxyz andydotxyz merged commit 50c5a3d into fyne-io:develop Jul 30, 2023
@andydotxyz andydotxyz deleted the fix/4080 branch July 30, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jacalz Jacalz Jacalz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andydotxyz @coveralls @Jacalz