Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix postion of line during deletion #4052

Merged
merged 2 commits into from
Jul 22, 2023
Merged

Fix postion of line during deletion #4052

merged 2 commits into from
Jul 22, 2023

Conversation

andydotxyz
Copy link
Member

@andydotxyz andydotxyz commented Jul 11, 2023 •
edited
Loading

Description:

Fixes #3905

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

Jacalz
Jacalz reviewed Jul 18, 2023
View reviewed changes
Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment inline. It also seems like the tests are failing

container/doctabs.go Show resolved Hide resolved
@andydotxyz
Copy link
Member Author

Apologies I opened the PR on a computer where the tests don't work and forgot to come back to it as I took a few days off. It's the M1/2 test issue that is hiding me back, need to get to the bottom of it!

@andydotxyz andydotxyz requested a review from Jacalz July 21, 2023 10:27
@andydotxyz andydotxyz merged commit 4a0f231 into fyne-io:develop Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jacalz Jacalz Jacalz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andydotxyz @Jacalz