Skip to content

Make the password accessory look and behave disabled when the entry is disabled #3914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2023
Merged

Make the password accessory look and behave disabled when the entry is disabled #3914

merged 1 commit into from
May 24, 2023

Conversation

andydotxyz
Copy link
Member

@andydotxyz andydotxyz commented May 24, 2023 •
edited by Jacalz
Loading

Fixes #3908

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

Coverage Status

Coverage: 62.007% (+0.007%) from 62.0% when pulling 350b325 on andydotxyz:fix/3908 into 6209d60 on fyne-io:develop.

@Jacalz
Copy link
Member

Jacalz commented May 24, 2023

You had accidentally pasted the wrong commit into the commit. I updated the PR description with #3908 but I would recommend that you squash merge the PR to be able to change the description of the commit before merging.

Jacalz
Jacalz requested changes May 24, 2023
View reviewed changes
Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor note about an unnecessary setup of image tests.

widget/entry_test.go
Comment on lines +1740 to +1741
entry, window := setupPasswordTest(t)
defer teardownImageTest(window)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you really need to do this when not using any image tests?

BTW: I noticed that that function is writing to the same markup test file on each call which seems unnecessary. Will push a new PR to fix that.

Jacalz
Jacalz approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@Jacalz Jacalz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realised that the new code is in line with the old code and isn't technically doing anything wrong. I'll fix the function on develop some time in the future to make sure that we aren't updating that markup on each test setup.

@andydotxyz andydotxyz merged commit b532dc6 into fyne-io:develop May 24, 2023
@andydotxyz andydotxyz deleted the fix/3908 branch May 24, 2023 22:04
@andydotxyz
Copy link
Member Author

Thanks for fixing it up. I am over tired this week!

andydotxyz added a commit that referenced this pull request May 25, 2023
@andydotxyz
Make the password accessory look and behave disabled when the entry i…
d4e02f7 
…s disabled (#3914)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jacalz Jacalz Jacalz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andydotxyz @coveralls @Jacalz