Make sure we have sufficient space for the bar as well if content is tiny #3898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jacalz
requested changes
May 20, 2023
Sorry about that, was away from the machine a couple days. Fixed now |
Jacalz
requested changes
May 22, 2023
There was a problem hiding this comment.
This PR does unfortunately seem to introduce various bugs with the showing and hiding of tabs. One thing I noticed is that the window sometimes becomes larger when selecting a different tab if there are tabs in the dropdown menu:
Screencast.from.2023-05-22.20-31-36.webm
I also noticed that you can't make the window smaller again if you make it large enough to show more tabs:
Screencast.from.2023-05-22.20-33-40.webm
|
Thanks for catching that, should be fixed now |
Jacalz
reviewed
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3885
Checklist: