Deprecate theme.FyneLogo() function

[Jacalz]

Description:

This deprecates the theme.FyneLogo() function as discussed on a call a few months back. Developers should use their own application icons instead. Anyone that needs a Fyne logo can bundle it manually.

Fixes #3296

Checklist:

• Tests included.
• Lint and formatter run with no errors.
• Tests all pass.

Where applicable:

• Any breaking changes have a deprecation path or have been discussed.

[coveralls]

Coverage: 61.776% (+0.004%) from 61.772% when pulling 1b52d05 on Jacalz:deprecate-fynelogo into 0e70551 on fyne-io:develop.

[andydotxyz]

A couple of minor things inline. But yes we need to figure what the default for tray/app icon is and keep it consistent. I'm not sure that no-icon works in the tray context?

[andydotxyz]

I don't think this should have been committed - it is part of a flakey test that needs more work

[Jacalz]

Good point. I made sure to restore it

[andydotxyz]

I think it needs the FyneApp.toml references updated too

[Jacalz]

But yes we need to figure what the default for tray/app icon is and keep it consistent. I'm not sure that no-icon works in the tray context?

Absolutely. You are right. It is currently changed to use the warning icon but the error icon could work as well. Another idea of mine was to use the question icon. What would you prefer?

[vcscsvcscs]

LGTM

[andydotxyz]

But yes we need to figure what the default for tray/app icon is and keep it consistent. I'm not sure that no-icon works in the tray context?

Absolutely. You are right. It is currently changed to use the warning icon but the error icon could work as well. Another idea of mine was to use the question icon. What would you prefer?

Maybe instead of re-using we should actually have an "icon missing" icon? then app developers can replace it using the theme without changing one of those dialog icons...

[Jacalz]

That sounds like a good plan. I'll go ahead with getting that sorted in a few days

[Jacalz]

I can't seem to find any icon in material design to indicate that an icon is missing. It does put a stick in the wheel so to say.
There are a few options that we should consider:

1. Does someone else have more luck with finding one? :)
2. Should we consider any other icons from what we already have? Suitable ones would be Cancel, Warning or Question.
3. If both above are not possible, should we perhaps abandon this?

[andydotxyz]

There is also HelpIcon which is (currently) more filled in and might make a better fallback icon?

[andydotxyz]

This is what we have used in Fyne Desk when an app has no icon https://fonts.google.com/icons?selected=Material%20Symbols%20Outlined%3Abroken_image%3AFILL%400%3Bwght%40400%3BGRAD%400%3Bopsz%4048

[Jacalz]

This is what we have used in Fyne Desk when an app has no icon https://fonts.google.com/icons?selected=Material%20Symbols%20Outlined%3Abroken_image%3AFILL%400%3Bwght%40400%3BGRAD%400%3Bopsz%4048

Thanks. That's wonderful. I was trying to find icons with missing but not broken when I was looking. That icon will do nicely.

[Jacalz]

I had to force-push a rebase on develop. Something seemed strange with the test where it expected foreground_ at the beginning of the name yet none of the other files had it.

[andydotxyz]

I had to force-push a rebase on develop. Something seemed strange with the test where it expected foreground_ at the beginning of the name yet none of the other files had it.

The foreground_ prefix should be on every default themed resource name now, it was a fix to a cache overlap bug earlier this month

[Jacalz]

Yeah, I remember it being added but the test were strange. None of the other icon tests included the change so I didn’t either. However, my code still failed because it was missing foregroundz. Strange. Either way, this should be fine now :)

[andydotxyz]

Nice