Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash in storage.List #3311

Closed
wants to merge 1 commit into from
Closed

Conversation

b5710546232
Copy link
Contributor

Description:

Fixes #3287
I added checking for length of prefix that caused application crash.

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

Where applicable:

  • Public APIs match existing style and have Since: line.
  • Any breaking changes have a deprecation path or have been discussed.
  • Updated the vendor folder (using go mod vendor).
  • Check for binary size increases when importing new modules.

@b5710546232 b5710546232 mentioned this pull request Oct 5, 2022
7 tasks
@Jacalz
Copy link
Member

Jacalz commented Oct 5, 2022

I think something is strange here. You are still trying to merge your master branch (likely out of sync with the develop branch) into the develop branch here but the workflows do not match. We need to approve workflows but because the workflows are not the same as what is required, I actually can’t approve them. There is no button to do so :/

You need to base your changes on the develop branch first.

@b5710546232
Copy link
Contributor Author

I see, I will close this one and try it again.

@b5710546232 b5710546232 closed this Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants